Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation Error Fix #90

Open
wants to merge 3 commits into
base: spree-2-1-wip
Choose a base branch
from
Open

Translation Error Fix #90

wants to merge 3 commits into from

Conversation

Ruekompa
Copy link

Fixes Translation Missing Error for ad_hoc_options select_tag

Russell Kompinski added 3 commits December 12, 2013 13:33
Fixes Translation Missing Error for Add
Fixes Translation Missing error on ad_hoc select_tag
Seems to fix fire_event error. You can define the fire_event, and try and populate the way the promotions works. But this seems to work. I don't know if it's right. I'm just running the order.update! method
@binaryphile
Copy link
Contributor

I'm experiencing the translation error in production for the ad-hoc options select tag. This commit seems to fix that but also does something else to fire_event, which looks like the cause of the travis ci build failing.

I wish I could get the translation fix from here without necessarily the fire_event fix. Could these be broken up and the translation accepted, Jeff?

@Ruekompa
Copy link
Author

Ruekompa commented Feb 6, 2014

Hey binary, what I did was install the gem manually in a specified location. I get errors with the fire event, which is why I removed it. Im using postgres for production and the fire event error persisted. I heard if you use mysql it works but haven't confirmed that. But I should have submitted pull request separate. Sorry still not great with git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants